PHP 5.2 > 5.3 (малко фиксове на грешки)

G

gearfight

Registered
Става дума за банлиста за CS 1.6 сървъри.
Проблема е там, че е писана под 5.2 и аз съм на 5.3 и има малко грешчици, които според мен са лесни за поправяне, ама дали е така... Точно не знам.

Ето какво имам като грешки в логовете:
[Thu Jun 13 15:02:20 2013] [error] [client 127.0.0.1] PHP Notice: Undefined index: lang in /var/www/banlist/include/config.inc.php on line 64, referer: http://localhost/
[Thu Jun 13 15:02:20 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: page in /var/www/banlist/ban_list.php on line 59, referer: http://localhost/
[Thu Jun 13 15:02:20 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: title2 in /var/www/banlist/ban_list.php on line 204, referer: http://localhost/
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined index: loggedin in /var/www/banlist/login.php on line 4, referer: http://localhost/banlist/ban_list.php
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: msg in /var/www/banlist/login.php on line 142, referer: http://localhost/banlist/ban_list.php
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: loginblocked in /var/www/banlist/login.php on line 144, referer: http://localhost/banlist/ban_list.php
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: loginfailed in /var/www/banlist/login.php on line 146, referer: http://localhost/banlist/ban_list.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Use of undefined constant total - assumed 'total' in /var/www/banlist/view.php on line 138, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Use of undefined constant permanent - assumed 'permanent' in /var/www/banlist/view.php on line 139, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Use of undefined constant active - assumed 'active' in /var/www/banlist/view.php on line 140, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Use of undefined constant temp - assumed 'temp' in /var/www/banlist/view.php on line 141, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Use of undefined constant admins - assumed 'admins' in /var/www/banlist/view.php on line 142, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Use of undefined constant servers - assumed 'servers' in /var/www/banlist/view.php on line 143, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: addons_array in /var/www/banlist/view.php on line 192, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: rules in /var/www/banlist/view.php on line 193, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: rules_array in /var/www/banlist/view.php on line 194, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: anticheat_array in /var/www/banlist/view.php on line 195, referer: http://localhost/banlist/search.php
[Thu Jun 13 15:07:28 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: error in /var/www/banlist/view.php on line 198, referer: http://localhost/banlist/search.php
Увеличете...

Това са всичките грешки които искам да оправя, не са много, но все пак скрипта работи и с тях, но искам всичко да е чисто и да няма по логовете подобни изцепки.

Започвам да давам инфо (код от самите файлове и от съответните редове) от горе-надолу.:
[Thu Jun 13 15:02:20 2013] [error] [client 127.0.0.1] PHP Notice: Undefined index: lang in /var/www/banlist/include/config.inc.php on line 64, referer: http://localhost/
//save current language to session
if(!$_SESSION["lang"])
$_SESSION["lang"]=$config->default_lang;

//load smilies to global array
if(empty($smilies)) {
$sql = mysql_query("SELECT code, url, name FROM ".$config->db_prefix."_smilies ORDER BY id");
while (list($code, $url, $name) = mysql_fetch_array($sql))
{
$name = stripslashes($name);
$name = htmlentities($name);
$smilies[]=array($code,$url,$name);
}
}
Увеличете...
PP: Само това е свързано с lang, дал съм код от ред 64 и малко надолу. (ако ви трябва нещо друго - казвайте)

Следваща грешка е:
[Thu Jun 13 15:02:20 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: page in /var/www/banlist/ban_list.php on line 59, referer: http://localhost/
$ban_page_curr=($page==0 || $page>$ban_page_max) ? 1:$page;
//calc mysql limits from current site
$min=($config->bans_per_page * $ban_page_curr)-$config->bans_per_page;
//build array with site info
$ban_page=array(
"current" => $ban_page_curr, //current site
"max_page" => ($ban_page_max)? $ban_page_max:1, //last site
"per_page" => $config->bans_per_page, //bans per page
"first_ban" => ($ban_count[0])? $min + 1:$min, //+1: LIMIT 0 is the first ban
"max_ban" => $ban_count[0], //count activ bans
"all_ban" => $ban_count[1] //count all bans
);
Увеличете...
Ред 59 и малко надолу до 70.

Следваща:
[Thu Jun 13 15:02:20 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: title2 in /var/www/banlist/ban_list.php on line 204, referer: http://localhost/
$smarty->assign("meta","");
$smarty->assign("title",$title);
$smarty->assign("title2",$title2);
$smarty->assign("version_web",$config->v_web);
if(file_exists("templates/".$config->design."/main_header.tpl")) {
$smarty->assign("design",$config->design);
}
Увеличете...
Дал съм от 202 до 208 и съм маркирал това което го дава като грешка.

Следваща:
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined index: loggedin in /var/www/banlist/login.php on line 4, referer: http://localhost/banlist/ban_list.php
if($_SESSION["loggedin"]) {
header("Location:index.php");
}
Увеличете...

Следваща:
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: msg in /var/www/banlist/login.php on line 142, referer: http://localhost/banlist/ban_list.php
$smarty->assign("meta","");
$smarty->assign("title",$title);
$smarty->assign("section",$section);
$smarty->assign("banner",$config->banner);
$smarty->assign("banner_url",$config->banner_url);
$smarty->assign("version_web",$config->v_web);
$smarty->assign("dir",$config->document_root);
$smarty->assign("this",$_SERVER['PHP_SELF']);
$smarty->assign("menu",$menu);
$smarty->assign("msg",$msg);
Увеличете...
Дал съм код от 133 до 142


[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: loginblocked in /var/www/banlist/login.php on line 144, referer: http://localhost/banlist/ban_list.php
и:
[Thu Jun 13 15:02:21 2013] [error] [client 127.0.0.1] PHP Notice: Undefined variable: loginfailed in /var/www/banlist/login.php on line 146, referer: http://localhost/banlist/ban_list.php

КОД:
if($loginblocked) {
$smarty->assign("block_left",$block_left);
} else if($loginfailed) {
$smarty->assign("try",$try);
}
Увеличете...


Нека първо да оправим тези и после ще дам код и от другите файлове. Прикачвам и файловете (3 на брой: Login.php, ban_list.php и config.inc.php):
http://dox.bg/files/dw?a=7f1af400e4

Благодаря на всеки отзовал се :)
 
http://www.php.net/manual/bg/migration53.changes.php

Most improvements in PHP 5.3.x have no impact on existing code

Когато си бил на 5.2 най-вероятно опцията Error Reporting ти е била сетната
PHP: 
error_reporting(E_ALL ^ E_NOTICE);  // Показвай всички без PHP NOTICE

А сега когато си на 5.3 тя е
PHP: 
error_reporting(E_ALL); // Показвай всички

AMX BANS винаги си ги е имала тези грешки.Те не са фатални, ако искаш разбира се може да ги оправиш.

Има доста уроци в интернет как да спреш или ограничиш error reporting-а.
 
Трябва да си влезнал или регистриран, за да отговориш тук.

Back
Горе